-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add identity secrets engine: Entity
, EntityAlias
, Group
and GroupAlias
#77
Add identity secrets engine: Entity
, EntityAlias
, Group
and GroupAlias
#77
Conversation
030f518
to
74bd058
Compare
Entity
, EntityAlias
, Group
and GroupAlias
Entity
, EntityAlias
, Group
and GroupAlias
Co-authored-by: alif <hexc@protonmail.com> Co-authored-by: andris <andris.varavs@lmt.lv>
74bd058
to
ea5866d
Compare
I've just rebased on master to get the latest changes, this is ready for further review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cosmetic stuff and typo fixes functionality looks good. Nice work! 👍
Also, pleas remove the extra API function I came up with 2 options to solve this:
Let me know what you are thinking about the solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about the issue with the empty response again, and I came up with that solution to solve this.
Let me know what you think about it.
Co-authored-by: Hännetz <34142036+Haennetz@users.noreply.github.com>
Thanks for taking time to review this! I think the suggested solution to the "maybe empty result" problem is fine, I would like to suggest another alternative before I go to implement it. Maybe we can just remove the The main advantage of this is that we could then return directly a This does have the disadvantage to not be conformed to the create entity/group official doc, as we won't support updating through this method. But as long as we make it clear that the user should directly use the update method, I think it's fine. Anyway, that's just a suggestion, and I'm totally fine going with the proposed solution. Please let me know what you think about this. |
Thanks for your suggestion i think it is a beeter way. |
84a8ed2
to
39c416d
Compare
39c416d
to
38d2f20
Compare
This PR is a follow-up of #64 and #38 that include the review feedback plus the missing methods.
It implements all the endpoint for
Entity
,EntityAlias
,Group
andGroupAlias
Most of the job is done, it's still a draft because I want to polish theentity::create
andgroup::create
with the same tricks I used forentity_alias::create
andgroup_alias::create
.