Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define STRICT_R_HEADERS, include float.h, adjust dbl eps constant #13

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

eddelbuettel
Copy link
Contributor

Hi Jeffrey, Hi circumplex team,

Your CRAN package circumplex uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at
RcppCore/Rcpp#1158
and the links therein for more context on this.

Here, I prefixed one #include <Rcpp.h> with STRICT_R_HEADERS. One additional change that is needed is the #include <float.h> (the compiler may suggst the C++ header #include , that is equivalent). We now can use DBL_EPSILON in two places.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by
RcppCore/Rcpp#1158
to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

@jmgirard
Copy link
Owner

Appreciate the pull request and not just an email - made it very easy on me.

@eddelbuettel
Copy link
Contributor Author

Thanks for the very swift action, and kind note. I tend to agree -- it is also 'more precise' that copying patches from email. It helps to have URL in DESCRIPTION pointing to the a public repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants