[currency] - fix rpc.service attribute (open-telemetry#1333)

* add package name for rpc.service attribute Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add package name for rpc.service attribute Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add package name for rpc.service attribute Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add package name for rpc.service attribute Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
jmichalak9 · Jan 19, 2024 · 4ba25fa · 4ba25fa
1 parent c617b64
commit 4ba25fa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ release.
 
 * [grafana] update grafana to 10.2.3
   ([#1332](https://github.com/open-telemetry/opentelemetry-demo/pull/1332))
+* [currencyservice] - add package name prefix to `rpc.service` attribute
+  ([#1333](https://github.com/open-telemetry/opentelemetry-demo/pull/1333))
 
 ## 1.7.2
 

diff --git a/src/currencyservice/src/server.cpp b/src/currencyservice/src/server.cpp
@@ -113,7 +113,7 @@ class CurrencyService final : public oteldemo::CurrencyService::Service
     auto span =
         get_tracer("currencyservice")->StartSpan(span_name,
                                       {{SemanticConventions::kRpcSystem, "grpc"},
-                                       {SemanticConventions::kRpcService, "CurrencyService"},
+                                       {SemanticConventions::kRpcService, "oteldemo.CurrencyService"},
                                        {SemanticConventions::kRpcMethod, "GetSupportedCurrencies"},
                                        {SemanticConventions::kRpcGrpcStatusCode, 0}},
                                       options);
@@ -173,7 +173,7 @@ class CurrencyService final : public oteldemo::CurrencyService::Service
     auto span =
         get_tracer("currencyservice")->StartSpan(span_name,
                                       {{SemanticConventions::kRpcSystem, "grpc"},
-                                       {SemanticConventions::kRpcService, "CurrencyService"},
+                                       {SemanticConventions::kRpcService, "oteldemo.CurrencyService"},
                                        {SemanticConventions::kRpcMethod, "Convert"},
                                        {SemanticConventions::kRpcGrpcStatusCode, 0}},
                                       options);