add an option that allow the replacement of the authentication by the new token. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@gauthierl: Apologies for the delay, but I'm going to have to put this off for a few more weeks while I tend to other tasks. |
|
No problem. I will use my fork in production... |
|
Any news, any plans ? |
|
Hi, I would really like this feature. This pull request looks much better then my blunt deletion of the return statement ;-). Any chance you're going to merge this pull request? thanks! |
jmikola
added a commit
that referenced
this pull request
Jan 23, 2015
|
Just merged in eda014b. I changed the option to a boolean flag and added some documentation for it in the readme. I'm going to take care of jmikola/JmikolaAutoLoginBundle#8 now and then I'll tag new versions of both libraries (this PR will be in AutoLogin 1.2.0). Thanks, @gauthierl! |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to let users switch from an account to another just by following a link containing token without requiring him to logout before. Note, that the commit did not change the current behavior: the token continue to be ignored if an user is already authenticate until you change an option.
I don't know if it's the good way to implement it. Any comments are welcome !