Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GeoJson\Feature\Feature::getGeometry() return type #24

Merged
merged 2 commits into from
Nov 18, 2016
Merged

Fix GeoJson\Feature\Feature::getGeometry() return type #24

merged 2 commits into from
Nov 18, 2016

Conversation

toooni
Copy link
Contributor

@toooni toooni commented Oct 19, 2016

  • The default value for properties should be an array
  • Fixed phpdoc to support autocompletion

@jmikola jmikola merged commit 844e43a into jmikola:master Nov 18, 2016
jmikola added a commit that referenced this pull request Nov 18, 2016
@jmikola
Merge pull request #24
980408c
@jmikola
Copy link
Owner

jmikola commented Nov 18, 2016

Thanks!

jeromegamez added a commit to beste/jmikola-geojson that referenced this pull request Jan 17, 2022
@jeromegamez
Re-enable Features to have properties with a null value.
cff24ec 
This reverts the change in the constructor introduced in
jmikola#24, since it broke the tests.

According to https://www.rfc-editor.org/rfc/rfc7946#section-3.2,
the `properties` member is an object (associative array), or null.
@jeromegamez jeromegamez mentioned this pull request Jan 18, 2022
Closed
jeromegamez added a commit to beste/jmikola-geojson that referenced this pull request Jan 18, 2022
@jeromegamez
Re-enable Features to have properties with a null value.
87d58aa 
This reverts the change in the constructor introduced in
jmikola#24, since it broke the tests.

According to https://www.rfc-editor.org/rfc/rfc7946#section-3.2,
the `properties` member is an object (associative array), or null.
jeromegamez added a commit to beste/jmikola-geojson that referenced this pull request Jan 20, 2022
@jeromegamez
Re-enable Features to have properties with a null value.
6910503 
This reverts the change in the constructor introduced in
jmikola#24, since it broke the tests.

According to https://www.rfc-editor.org/rfc/rfc7946#section-3.2,
the `properties` member is an object (associative array), or null.
jmikola pushed a commit that referenced this pull request Jan 21, 2022
@jeromegamez @jmikola
Re-enable Features to have properties with a null value.
db9276d 
This reverts the change in the constructor introduced in
#24, since it broke the tests.

According to https://www.rfc-editor.org/rfc/rfc7946#section-3.2,
the `properties` member is an object (associative array), or null.
@jmikola jmikola added this to the 1.0.3 milestone Apr 1, 2022
@jmikola jmikola changed the title simple fixes Fix GeoJson\Feature\Feature::getGeometry() return type Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@toooni @jmikola