-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GeoJSON type constants #42
Add GeoJSON type constants #42
Conversation
f1911fe
to
d7cafa8
Compare
Thanks for the contribution. I'll look into the CI failure (related to my Scrutinizer CI account) when I get a chance and get this PR merged/released. This would be a good use of enums; however, the install stats still show a significant number of pre-8.1 users so I don't think it'd be worth bumping for that reason alone. |
What about the enums, I don't really think, that it is the place, where is is really needed. |
A defined set of constants would be a fine case for a backed enum; however, I don't think it's worth bumping the language requirement of the package. Happy to keep things as they are in this PR. |
Would you like to add more checks like phpstan/phpcs or others? And when will you create new release?) I need it on my current project ^) |
I fixed the Scrutinizer issue. Please remove the |
3b3d4fb
to
9f4b255
Compare
done |
No description provided.