Merge pull request #73 from jmlopez-rod/hotfix/0.19.3

(hotfix) 0.19.3

CHANGELOG.md

@@ -8,6 +8,10 @@ The project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html)
 
 ## [Unreleased]
 
+## [0.19.3] <a name="0.19.3" href="#0.19.3">-</a> April 14, 2023
+
+- `review_release` ignores previously closed prs.
+
 ## [0.19.2] <a name="0.19.2" href="#0.19.2">-</a> April 10, 2023
 
 - Support python 3.11. `Foo.BAR` in Python 3.11 no longer returns the member
@@ -255,7 +259,8 @@ prs and the latest on the `master` branch.
 - Provides basic utilities to create a CI/CD flow via the m cli.
 - As a library, it facilities the creation of clis similar to m.
 
-[unreleased]: https://github.com/jmlopez-rod/m/compare/0.19.2...HEAD
+[unreleased]: https://github.com/jmlopez-rod/m/compare/0.19.3...HEAD
+[0.19.3]: https://github.com/jmlopez-rod/m/compare/0.19.2...0.19.3
 [0.19.2]: https://github.com/jmlopez-rod/m/compare/0.19.1...0.19.2
 [0.19.1]: https://github.com/jmlopez-rod/m/compare/0.19.0...0.19.1
 [0.19.0]: https://github.com/jmlopez-rod/m/compare/0.18.1...0.19.0

m/m.yaml

@@ -1,4 +1,4 @@
 owner: jmlopez-rod
 repo: m
-version: 0.19.2
+version: 0.19.3
 workflow: m_flow

packages/python/m/ci/review_release.py

@@ -92,18 +92,19 @@ def acknowledge_git_status(status: str) -> OneOf[Issue, None]:
     return issue('operation cancelled by user')
 
 
-def inspect_prs(prs: list[PullRequest]) -> OneOf[Issue, None]:
+def inspect_prs(all_prs: list[PullRequest]) -> OneOf[Issue, None]:
     """Inspect the release pull requests.
 
     There should not be any pull requests when calling `review_release`.
     This is a one time operation.
 
     Args:
-        prs: The list of pull requests.
+        all_prs: The list of pull requests.
 
     Returns:
         An issue if prs already exist, None otherwise.
     """
+    prs = [pr for pr in all_prs if pr.closed is False]
     if prs:
         return issue('release is already in review', context={
             'prs': {pr.number: pr.url for pr in prs},

packages/python/tests/cli/commands/review_release/fixtures/cancelled.json

@@ -0,0 +1,32 @@
+{
+  "data": {
+    "repository": {
+      "pullRequests": {
+        "nodes": [
+          {
+            "closed": true,
+            "title": "(hotfix) 0.5.1",
+            "number": 31,
+            "baseRefName": "master",
+            "mergeable": "MERGEABLE",
+            "merged": false,
+            "author": { "login": "jmlopez-rod" },
+            "latestReviews": { "nodes": [] },
+            "url": "https://github.com/jmlopez-rod/git-flow/pull/31"
+          },
+          {
+            "closed": true,
+            "title": "(hotfix to develop) 0.5.1",
+            "number": 32,
+            "baseRefName": "develop",
+            "mergeable": "MERGEABLE",
+            "merged": false,
+            "author": { "login": "jmlopez-rod" },
+            "latestReviews": { "nodes": [] },
+            "url": "https://github.com/jmlopez-rod/git-flow/pull/32"
+          }
+        ]
+      }
+    }
+  }
+}

packages/python/tests/cli/commands/review_release/test_review_release.py

@@ -34,6 +34,15 @@
             '"32": "https://github.com/jmlopez-rod/git-flow/pull/32"',
         ],
     ),
+    TCase(
+        branch='release/0.1.0',
+        exit_code=1,
+        graphql_response='cancelled.json',
+        user_input=['no'],
+        errors=[
+            'operation cancelled by user',
+        ],
+    ),
     TCase(
         branch='release/0.1.0',
         exit_code=1,

packages/python/tests/run.sh

@@ -13,5 +13,5 @@ else
 # To run specific tests:
 # python -m unittest discover -s packages/python -v -k tests.cli.commands.test_json.CliJsonTest
 # python -m pytest -vv -k test_m_npm
-  pytest -p no:logging packages/python -vv -k test_free_flow
+  pytest -p no:logging packages/python -vv -k test_m_review_release
 fi