Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply setup-py-upgrade #178

Merged
merged 5 commits into from
Nov 11, 2020
Merged

Conversation

graingert
Copy link
Contributor

Changes proposed in this pull request:

  • apply setup-py-upgrade
  • move setuptools_scm config to pyproject.toml

@graingert graingert changed the title Apply setup py upgrade Apply setup-py-upgrade Nov 11, 2020
setup.cfg Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #178 (b2785e9) into master (184269e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #178   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          569       569           
=========================================
  Hits           569       569           
Flag Coverage Δ
GHA_Ubuntu 100.00% <ø> (ø)
GHA_Windows 100.00% <ø> (ø)
GHA_macOS 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184269e...b2785e9. Read the comment docs.

@hugovk
Copy link
Collaborator

hugovk commented Nov 11, 2020

Thanks for this!

I've not used setup-py-upgrade before, but I'd like to use it on some other repos. Just to try it out, I ran it on master but it said:

$ setup-py-upgrade .
use_scm_version= is not supported in setup.cfg

Any tips?


Please could you also run setup-cfg-fmt and add it to pre-commit?

@graingert
Copy link
Contributor Author

graingert commented Nov 11, 2020

@hugovk I manually deleted that line and restored it after running setup-py-upgrade

@graingert
Copy link
Contributor Author

@hugovk I've now applied setup-cfg-fmt

@hugovk hugovk added the changelog: Changed For changes in existing functionality label Nov 11, 2020
@hugovk hugovk merged commit 36bc853 into jmoiron:master Nov 11, 2020
@hugovk
Copy link
Collaborator

hugovk commented Nov 11, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants