Fix bulk insert with one field #710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failed, yet. |
Pull Request Test Coverage Report for Build 210
💛 - Coveralls |
podhmo
force-pushed
the
fix-bulk-insert-with-one-field
branch
from
0f772c8 to
1c63f0a
Compare
podhmo
commented
Mar 13, 2021
| _, _, now := defaultSchema.Postgres() | ||
| return fmt.Sprintf("INSERT INTO val (k, v, added_at) VALUES (:k, :v, %v)", now) | ||
| }(), | ||
| expected: "INSERT INTO val (k, v, added_at) VALUES (?, ?, now()),(?, ?, now())", |
There was a problem hiding this comment.
Supports only no-arguments function (e.g. now()).
podhmo
commented
Mar 13, 2021
| // extra operation | ||
| { | ||
| values: []interface{}{vs[0], vs[1]}, | ||
| q: "INSERT INTO val (k,v) VALUES (:k,:v) ON DUPLICATE KEY UPDATE v = VALUES(v)", |
There was a problem hiding this comment.
For this, I changed the regex values to start with "VALUES".
There was a problem hiding this comment.
( But when this feature is used other than bulk insert (e.g. used in NamedQuery), this changes is broken )
podhmo
commented
Mar 13, 2021
| q: "INSERT INTO val (k) VALUES (:k)", | ||
| expected: "INSERT INTO val (k) VALUES (?)", | ||
| }, | ||
| { |
|
#718 is almost same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #709, #694