This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Bugfix/issue 262 page info missing on communities #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Included PageInfo object as an instance variable in the GetCommunityDetailsResponse component. I also included a
listAllWithPages(Pageable pageable) method which returns Page object in the CommunityService interface, and implemented in the CommunitySDJpaService. This method was used in the listAllCommunities method in the CommunityController class.
📄 Motivation and Context
When you list all communities by GET /communities, you get all the communities in a communities array, you can also page
them using page and size query parameters, but no pageInfo object is returned, which is required for further pagination
on the front-end.
This change was added to include page information to navigate the list of communities returned by the GET /communities
request.
#262
🧪 How Has This Been Tested?
Mockito unit test and postman test
📷 Screenshots (if appropriate)
📦 Types of changes
✅ Checklist