Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Bugfix/issue 262 page info missing on communities #277

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bayotheman
Copy link

🚀 Description

Included PageInfo object as an instance variable in the GetCommunityDetailsResponse component. I also included a
listAllWithPages(Pageable pageable) method which returns Page object in the CommunityService interface, and implemented in the CommunitySDJpaService. This method was used in the listAllCommunities method in the CommunityController class.

📄 Motivation and Context

When you list all communities by GET /communities, you get all the communities in a communities array, you can also page
them using page and size query parameters, but no pageInfo object is returned, which is required for further pagination
on the front-end.
This change was added to include page information to navigate the list of communities returned by the GET /communities
request.
#262

🧪 How Has This Been Tested?

Mockito unit test and postman test

📷 Screenshots (if appropriate)

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project(Do your best to follow code styles. If none apply just skip this).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…geable) method to account for paging in the Get /communities endpoint response.
…geable) method to account for paging in the Get /communities endpoint response.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant