Fixing issue where plugin was still writing to stream when closed off #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incomplete (missing the
options.banner
prepend, and broken tests) but I did find the culprit of #350.Basically, instead of using the
bundle
callback, we need topipe
instead (see here), as the latter ensures that the entirepipeline
is complete before piping. In this case - that all the files in the pipeline have completed. (You can see factor-bundle here is adding the files to the browserify pipeline).That said, I'm not using the grunt writer - I'm not that familiar with grunt - is that a concern?
This is obviously a significant change, and hence I wanted to run it by you first @tleunen. (Also, I changed the
self
tobind(this)
as I went along, as I loathe theself = this
pattern. It's not a deal-breaker though by any means)