Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions and jest #14

Merged
merged 10 commits into from
Oct 24, 2023
Merged

Conversation

nicolasbrugneaux
Copy link
Collaborator

@nicolasbrugneaux nicolasbrugneaux commented Oct 10, 2023

Inspired by #3 but modernized. Will add a similar test case

Note: Looks like a lot of changes because it's based on the following PR:

I will rebase it when it's merged.

@nicolasbrugneaux
Copy link
Collaborator Author

Quick write-up regarding testing:

For most tests, a funded wallet is necessary to deploy a test contract, send a transaction with or without feeCurrencies. I came up with 3 solutions and we need to decide what makes more sense:

  • 1 constant account (set-up by @jmrossy) with enough funds for the forseeable future
  • 1 new account per CI run (meaning some integration with celotooljs to usethe faucet programmatically)
  • a mock environment (such as ganache) but the big caveat is the inability to test celo-key features such as fee-currency.

My best bet would be on solution#1, much easier to setup, but it's obviously less elegant (and may run out of funds, who knows)

@jmrossy
Copy link
Owner

jmrossy commented Oct 10, 2023

I agree #1 is fine for now and definitely simplest

@nicolasbrugneaux
Copy link
Collaborator Author

Now that #13 was merged, I'll tackle this on Monday, can I ask you to setup an process.env.MNEMONIC for this repo (or give me permission to add it? I think process.env.ACCOUNT should be refactored to not be needed

@jmrossy
Copy link
Owner

jmrossy commented Oct 20, 2023

@nicolasbrugneaux Done. I've created the repo secret (called just MNEMONIC) and given you write perms on this repo :)

@nicolasbrugneaux nicolasbrugneaux changed the title [WIP] GitHub actions and jest GitHub actions and jest Oct 23, 2023
@nicolasbrugneaux nicolasbrugneaux marked this pull request as ready for review October 23, 2023 14:13
yarn.lock Show resolved Hide resolved
src/lib/StaticCeloProvider.ts Outdated Show resolved Hide resolved
@nicolasbrugneaux
Copy link
Collaborator Author

@jmrossy jmrossy merged commit bf6f791 into jmrossy:master Oct 24, 2023
@nicolasbrugneaux nicolasbrugneaux deleted the ci/add-github-actions branch October 25, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants