-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions and jest #14
Conversation
Quick write-up regarding testing: For most tests, a funded wallet is necessary to deploy a test contract, send a transaction with or without feeCurrencies. I came up with 3 solutions and we need to decide what makes more sense:
My best bet would be on solution#1, much easier to setup, but it's obviously less elegant (and may run out of funds, who knows) |
I agree #1 is fine for now and definitely simplest |
f6ba263
to
8276b73
Compare
Now that #13 was merged, I'll tackle this on Monday, can I ask you to setup an |
@nicolasbrugneaux Done. I've created the repo secret (called just |
8276b73
to
5d8ad6d
Compare
cc84b84
to
312a76c
Compare
Tests are passing on the celo-org fork: https://github.com/celo-org/celo-ethers-wrapper/actions/runs/6629109115/job/18007671031 |
Inspired by #3 but modernized. Will add a similar test case
Note: Looks like a lot of changes because it's based on the following PR:
I will rebase it when it's merged.