-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale support for Romanian #12
Comments
I can assist here if needed. Besides translating the resource file is there anything else that should be done? Are there any tests? |
@beradrian We currently have tests only for English language. If you can contribute the translations and add some tests, that would be great. Thank you for looking into this! |
Take a look here: https://github.com/beradrian/cron-utils/tree/ro-ro The only problem is that new messages have to be defined at_second, at_minute, at_hour, at_month. Could you please make use of these in the code? If yes, I can modify the rest of the resources and tests will pass. There will also be nice if we can have something like between_month_x_and_y and between_weekday_x_and_y. The current one works, but this will enable to have a more natural format in Romanian (possible other languages too). |
@beradrian thank you for the contribution! |
@beradrian Romanian is now supported! 🚀 |
Add support for Romanian similar to @beradrian contribution.
The text was updated successfully, but these errors were encountered: