Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vae_example.ipynb #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update vae_example.ipynb #8

wants to merge 1 commit into from

Conversation

tayfununal
Copy link

I guess, D has forgotten in the equation.

@tayfununal
Update vae_example.ipynb
a717b87 
I guess, D has forgotten in the equation.
@jmtomczak
Copy link
Owner

No, this is not correct because log_var is of size mini_batch x D. When we calculate log_p , we treat all variables as tensors. Adding D as you suggest would result in scaling log_var which would be incorrect.
However, I spotted a different mistake. The constant shouldn't have D. I am going to correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tayfununal @jmtomczak