-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite wrapper script #94
Conversation
e298121
to
5c90e7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an extra space somewhere between line 123 and 124 in the wrapper?
5c90e7f
to
513818e
Compare
@ripleymj I just force pushed a change to fix that |
I think this works well enough to merge, but I'm going to hold off until later today when I can take one more look at the whole thing. |
513818e
to
9fbfebc
Compare
@ripleymj I pushed a change to rebase this on top of master to avoid merge conflicts |
b345533
to
90123dc
Compare
Forgot to comment but the latest version has refactored the dialog creation out to a separate method. It doesn't clean stuff up too much, but hopefully it makes the dialogs slightly more uniform |
90123dc
to
7959462
Compare
I've approved the changes. When you're ready, please merge, create a branch, and tag beta1. |
Need to rethink the effect on #90 here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Cancel is better labeled as Exit or Quit, since you can't really revert after a run. I might also just be trying out the shed paint.
I agree on the Cancel vs Quit |
bc921cd
to
a214a5e
Compare
Two more commits. One to fix an issue that may come up soon and another to make things cleaner should strings need to be updated in the future. |
Hopefully those are two of the last commits that need to be pushed (and one of the last reviews you'll need to do). When we get ready to merge, I'll rebase this whole thing on master and squash it all into one big commit. Any other changes before then I'll keep pushing as individual commits because I think they more clearly highlight what changes each time I push and make you have to re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejecting this out of spite.
Once all other remaining PRs are merged and we get a resolution to #84 I think we can go ahead and merge this monster as well |
e522f88
to
f43c64d
Compare
This has been rebased on top of master and all the commits have been squashed. |
Rewrite the Ansible wrapper script in Python to allow the user to select which courses they need to have their machine configured for. Enable logging by specifying a path in ansible.cfg. Remove previous wrappers and installed desktop shortcuts in favor of the new wrapper
f43c64d
to
bf411a0
Compare
Rewrite the Ansible wrapper script in Python to allow the user to select
which courses they need to have their machine configured for. Enable
logging by specifying a path in ansible.cfg. Remove previous wrappers
and installed desktop shortcuts in favor of the new wrapper
Resolves #93
Resolves #92
Closes #62