Map support in addition to the current CompositeData #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map support in addition to the current CompositeData
Update doc: Map support in addition to the current CompositeData
|
Thanks @cyrille-leclerc ! |
|
I get the following findbugs exception when building, I'm looking at this problem to release. |
cyrille-leclerc
added a commit
that referenced
this pull request
May 11, 2020
|
Well, I copied the construct of "if (attributeValue instanceof CompositeData)" in "if (attributeValue instanceof Map)" maintaining the same code-style, but entrySet is more efficient of course. |
|
Shipped in 1.2.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for a basic type easier and lighter to implement in applications than CompositeData.
Tested on OpenJDK 1.7.0_201