Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Please add timeout parameter to @BEDLEVELVISUALIZER #314

Closed
LMS0815 opened this issue Oct 28, 2020 · 1 comment · Fixed by #398
Closed

[FR]: Please add timeout parameter to @BEDLEVELVISUALIZER #314

LMS0815 opened this issue Oct 28, 2020 · 1 comment · Fixed by #398
Labels
enhancement New feature or request solved workaround documented or fix applied
Milestone

Comments

@LMS0815
Copy link

LMS0815 commented Oct 28, 2020

Please add a timeout value as optional parameter to @BEDLEVELVISUALIZER 30 which is overwriting the default from the settings.

This would be useful if you have various methods getting the mesh.

e.g. UBL:

@BEDLEVELVISUALIZER 30
G29 PT; Probe
G29 P3 T; calculate missing points and report
@BEDLEVELVISUALIZER 5
G29 T; Report only
@LMS0815 LMS0815 changed the title [FR]: Please add timeout value to @BEDLEVELVISUALIZER [FR]: Please add timeout parameter to @BEDLEVELVISUALIZER Oct 28, 2020
@jneilliii jneilliii added the enhancement New feature or request label Oct 28, 2020
@jneilliii jneilliii added this to the 1.0.1 milestone Jan 13, 2021
@jneilliii jneilliii added the solved workaround documented or fix applied label Jan 13, 2021
jneilliii added a commit that referenced this issue Jan 13, 2021
…on printer, #348

add optional timeout override to @BEDLEVELVISUALIZER command, #314
add settings button on tab for quick access, #349
@jneilliii
Copy link
Owner

Just added a version 1.0.1rc2 that adds this functionality. It's possible that you could experience a race condition if you make it too short, but it should be pretty obvious. If you want to test you can change the Release Channel for the plugin to Release Candidate in Octoprint's Software Update settings (assuming OctoPrint 1.5.0+).

@jneilliii jneilliii mentioned this issue Feb 28, 2021
jneilliii added a commit that referenced this issue Feb 28, 2021
**Added**
* optional timeout override to @BEDLEVELVISUALIZER command, #314
* settings button on tab for quick access, #349

**Updated**
* README.md adding note that auto bed leveling must be possible on printer, #348

**Fixed**
* allow for probe points that contain more than single digits, #352, #269
* resolve issues with circular beds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request solved workaround documented or fix applied
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants