This repository has been archived by the owner on Jun 16, 2024. It is now read-only.
Fix TypeError issue; send zeroes for RGB/W if dimmer is zero; improve logging #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 22, 2020 14:12
added 3 commits
September 27, 2020 20:19
jnimmo
reviewed
Apr 24, 2021
| @@ -323,18 +323,21 @@ def dmx_values(self): | |||
| return color_rgb_to_rgbw(*scaled_rgb) | |||
| elif self._type == CONF_LIGHT_TYPE_DRGB: | |||
| drgb = [self._brightness] | |||
| drgb.extend(self._rgb) | |||
| drgb.extend(self._rgb if self._brightness > 0 else [0, 0, 0]) | |||
| _LOGGER.debug("drgb: " + ', '.join([str(x) for x in drgb])); | |||
There was a problem hiding this comment.
Hey Ruth, sorry for the delay in getting to this. Can you help me understand why the RGB values should be zeroed for these lights? In my mind that's what the dimmer channel is there for.
There was a problem hiding this comment.
This was probably me being paranoid in the DRGB case then; however it won't do any harm for the RGB values to be zero if the dimmer channel is also zero, as the end result will be no light output either way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.