Add frozen_string_literal everywhere and fix string mutation with force_encoding

.rubocop.yml

@@ -66,6 +66,11 @@ Style/RegexpLiteral:
 Style/NumericLiterals:
   MinDigits: 6
 
+# Offense count: 0
+# Cop supports --auto-correct.
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: always
+
 # Offense count: 4
 # Cop supports --auto-correct.
 Lint/UnusedMethodArgument:

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 gemspec
 

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 begin
   require 'rspec/core/rake_task'
   RSpec::Core::RakeTask.new(:spec)

bin/httparty

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
 require "optparse"
 require "pp"
 

examples/aaws.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'active_support'
 

examples/basic.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/crack.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'crack'
 

examples/custom_parsers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/delicious.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/google.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/headers_and_user_agents.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # To send custom user agents to identify your application to a web service (or mask as a specific browser for testing), send "User-Agent" as a hash to headers as shown below.
 
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))

examples/logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'logger'

examples/nokogiri_html_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'nokogiri'
 

examples/rescue_json.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 

examples/rubyurl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/stackexchange.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/stream_download.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/tripit_sign_in.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 

examples/twitter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

examples/whoismyrep.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 require File.join(dir, 'httparty')
 require 'pp'

features/steps/env.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mongrel'
 require './lib/httparty'
 require 'rspec/expectations'

features/steps/httparty_response_steps.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Not needed anymore in ruby 2.0, but needed to resolve constants
 # in nested namespaces. This is taken from rails :)
 def constantize(camel_cased_word)

features/steps/httparty_steps.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 When /^I set my HTTParty timeout option to (\d+)$/ do |timeout|
   @request_options[:timeout] = timeout.to_i
 end

features/steps/mongrel_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'base64'
 class BasicMongrelHandler < Mongrel::HttpHandler
   attr_accessor :content_type, :custom_headers, :response_body, :response_code, :preprocessor, :username, :password
@@ -95,19 +97,19 @@ module DigestAuthenticationUsingMD5Sess
   def self.extended(base)
     base.custom_headers["WWW-Authenticate"] = %(Digest realm="#{REALM}",qop="#{QOP}",algorithm="MD5-sess",nonce="#{NONCE}",opaque="opaque"')
   end
-  
+
   def process(request, response)
     if authorized?(request)
       super
     else
       reply_with(response, 401, "Incorrect.  You have 20 seconds to comply.")
     end
   end
-  
+
   def md5(str)
     Digest::MD5.hexdigest(str)
   end
-  
+
   def authorized?(request)
     auth = request.params["HTTP_AUTHORIZATION"]
     params = {}

features/steps/remote_service_steps.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Given /a remote service that returns '(.*)'/ do |response_body|
   @handler = BasicMongrelHandler.new
   step "the response from the service has a body of '#{response_body}'"

lib/httparty.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pathname'
 require 'net/http'
 require 'net/https'

lib/httparty/connection_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HTTParty
   # Default connection adapter that returns a new Net::HTTP each time
   #
@@ -38,12 +40,12 @@ module HTTParty
   # in the #options attribute. It is up to you to interpret them within your
   # connection adapter. Take a look at the implementation of
   # HTTParty::ConnectionAdapter#connection for examples of how they are used.
-  # The keys used in options are 
+  # The keys used in options are
   # * :+timeout+: timeout in seconds
   # * :+open_timeout+: http connection open_timeout in seconds, overrides timeout if set
   # * :+read_timeout+: http connection read_timeout in seconds, overrides timeout if set
   # * :+debug_output+: see HTTParty::ClassMethods.debug_output.
-  # * :+cert_store+: contains certificate data. see method 'attach_ssl_certificates' 
+  # * :+cert_store+: contains certificate data. see method 'attach_ssl_certificates'
   # * :+pem+: contains pem client certificate data. see method 'attach_ssl_certificates'
   # * :+p12+: contains PKCS12 client client certificate data.  see method 'attach_ssl_certificates'
   # * :+verify+: verify the server’s certificate against the ca certificate.

lib/httparty/cookie_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class HTTParty::CookieHash < Hash #:nodoc:
   CLIENT_COOKIES = %w(path expires domain path secure httponly)
 

lib/httparty/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HTTParty
   # @abstact Exceptions raised by HTTParty inherit from Error
   class Error < StandardError; end

lib/httparty/hash_conversions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'erb'
 
 module HTTParty

lib/httparty/logger/apache_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HTTParty
   module Logger
     class ApacheFormatter #:nodoc:

lib/httparty/logger/curl_formatter.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module HTTParty
   module Logger
     class CurlFormatter #:nodoc:
       TAG_NAME = HTTParty.name
-      OUT      = '>'.freeze
-      IN       = '<'.freeze
+      OUT      = '>'
+      IN       = '<'
 
       attr_accessor :level, :logger
 

lib/httparty/logger/logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'httparty/logger/apache_formatter'
 require 'httparty/logger/curl_formatter'
 

lib/httparty/module_inheritable_attributes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HTTParty
   module ModuleInheritableAttributes #:nodoc:
     def self.included(base)

lib/httparty/net_digest_auth.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'digest/md5'
 require 'net/http'
 
@@ -14,11 +16,11 @@ def digest_auth(username, password, response)
 
       authenticator.authorization_header.each do |v|
         add_field('Authorization', v)
-      end 
+      end
 
       authenticator.cookie_header.each do |v|
         add_field('Cookie', v)
-      end      
+      end
     end
 
     class DigestAuthenticator
@@ -113,11 +115,11 @@ def md5(str)
       def algorithm_present?
         @response.key?('algorithm') && !@response['algorithm'].empty?
       end
-      
+
       def use_md5_sess?
         algorithm_present? && @response['algorithm'] == 'MD5-sess'
       end
-      
+
       def a1
         a1_user_realm_pwd =  [@username, @response['realm'], @password].join(':')
         if use_md5_sess?

lib/httparty/parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HTTParty
   # The default parser used by HTTParty, supports xml, json, html, csv and
   # plain text.
@@ -119,7 +121,7 @@ def xml
       MultiXml.parse(body)
     end
 
-    UTF8_BOM = "\xEF\xBB\xBF".freeze
+    UTF8_BOM = "\xEF\xBB\xBF"
 
     def json
       JSON.parse(body, :quirks_mode => true, :allow_nan => true)

lib/httparty/request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'erb'
 require 'httparty/request/body'
 
@@ -286,7 +288,7 @@ def encode_with_ruby_encoding(body, charset)
       # NOTE: This will raise an argument error if the
       # charset does not exist
       encoding = Encoding.find(charset)
-      body.force_encoding(encoding.to_s)
+      body.dup.force_encoding(encoding.to_s)
     rescue ArgumentError
       body
     end
@@ -298,16 +300,16 @@ def assume_utf16_is_big_endian
     def encode_utf_16(body)
       if body.bytesize >= 2
         if body.getbyte(0) == 0xFF && body.getbyte(1) == 0xFE
-          return body.force_encoding("UTF-16LE")
+          return body.dup.force_encoding("UTF-16LE")
         elsif body.getbyte(0) == 0xFE && body.getbyte(1) == 0xFF
-          return body.force_encoding("UTF-16BE")
+          return body.dup.force_encoding("UTF-16BE")
         end
       end
 
       if assume_utf16_is_big_endian
-        body.force_encoding("UTF-16BE")
+        body.dup.force_encoding("UTF-16BE")
       else
-        body.force_encoding("UTF-16LE")
+        body.dup.force_encoding("UTF-16LE")
       end
     end
 

lib/httparty/request/body.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'multipart_boundary'
 
 module HTTParty

lib/httparty/request/multipart_boundary.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'securerandom'
 
 module HTTParty

lib/httparty/response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HTTParty
   class Response < Object
     def self.underscore(string)
@@ -59,10 +61,10 @@ def nil?
       response.nil? || response.body.nil? || response.body.empty?
     end
 
-    def to_s      
+    def to_s
       if !response.nil? && !response.body.nil? && response.body.respond_to?(:to_s)
         response.body.to_s
-      else 
+      else
         inspect
       end
     end
@@ -80,7 +82,7 @@ def display(port=$>)
         parsed_response.display(port)
       elsif !response.nil? && !response.body.nil? && response.body.respond_to?(:display)
         response.body.display(port)
-      else 
+      else
         port.write(inspect)
       end
     end
@@ -89,7 +91,7 @@ def respond_to_missing?(name, *args)
       return true if super
       parsed_response.respond_to?(name) || response.respond_to?(name)
     end
-    
+
     protected
 
     def method_missing(name, *args, &block)