Update connection adapter to only trust ssl_ca_* #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies httparty's behavior to only trust the system CAs if ssl_ca_file and ssl_ca_path is not provided. As a user using my own CA, I only want to trust my CA. Not my CA and all the other CAs. This change in behavior was introduced in recent version of curl. Users wanting to trust both can add the system CA to ssl_ca_file or ssl_ca_path. Alternatively, they can (and should) use a different class for each backend they are connecting to. I didn't provide test cases as the current tests are broken and I couldn't find a way to fix them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies httparty's behavior to only trust the system CAs if ssl_ca_file and ssl_ca_path is not provided.
As a user using my own CA, I only want to trust my CA. Not my CA and all the other CAs.
This change in behavior was introduced in recent version of curl.
Users wanting to trust both can add the system CA to ssl_ca_file or ssl_ca_path. Alternatively, they can (and should) use a different class for each backend they are connecting to.
I didn't provide test cases as the current tests are broken and I couldn't find a way to fix them.