Skip to content

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Joana Sesinando committed Feb 10, 2021
1 parent 8244939 commit 6edb60c
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 12 deletions.
2 changes: 0 additions & 2 deletions src/app/_services/fenix/fenix.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ export class FenixService {

constructor(public translateService: TranslateService, public errorService: ErrorService) { }

// FIXME: degree in course??

/********************** CORRECT STRUCTURE **********************/

parseDegree(degreeJson): Degree {
Expand Down
7 changes: 0 additions & 7 deletions src/app/_util/testing.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ export class TestingService {

constructor() { }

/* --------------------------------------------------------------------------------
* Creates a Course focusing only on its shifts.
* -------------------------------------------------------------------------------- */
createShiftsOnlyCourse(shifts: Shift[]): Course { // FIXME: if not used remove
return new Course(this.COURSE_ID, this.COURSE_NAME, this.COURSE_ACRONYM, this.COURSE_SEMESTER, undefined, undefined, shifts);
}

/* --------------------------------------------------------------------------------
* Creates a Shift focusing only on time it occurs.
* --------------------------------------------------------------------------------
Expand Down
1 change: 0 additions & 1 deletion src/app/homepage/homepage.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ describe('HomepageComponent', () => {
});

describe('Preparing courses to generate schedules for', () => {
// TODO: patch A / B more tests
let course: Course;

beforeEach(() => {
Expand Down
4 changes: 2 additions & 2 deletions src/app/homepage/homepage.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export class HomepageComponent implements OnInit, AfterViewInit {
this.typesOfClassesPicked.clear();

// Clean selected courses
for (const course of this.selectedCourses) { // FIXME: no need?
for (const course of this.selectedCourses) {
this.removeCourse(course.id);
}

Expand Down Expand Up @@ -227,7 +227,7 @@ export class HomepageComponent implements OnInit, AfterViewInit {
this.loadCoursesBasicInfo(academicTerm, degreeID);

// Reset selected courses state
for (const course of this.stateService.selectedCourses) { // FIXME: no need?
for (const course of this.stateService.selectedCourses) {
this.addCourse(course.id);
}

Expand Down

0 comments on commit 6edb60c

Please sign in to comment.