-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write can be called multiple times, so adding a way to prevent writing headers #9
Write can be called multiple times, so adding a way to prevent writing headers #9
Conversation
Hello.. First of all. Thank you very much for the contribution. It's an awesome feeling to know that my project is actually useful for someone. So.. no worries about the build. That's something that I need to fix. About the change itself. Second, I'm not so sure that we need to change the public signature of the Write method in order to be called multiple times. What do you think? |
Hi there! I was actually reluctant to do that just because it changes the flow. Not sure who'd want to write headers in the middle of the file though, so the change does make sense. I'll change this PR! Thanks! |
Yup. My point exactly. |
d05fbd0
to
67bcd63
Compare
@joaomatossilva changed! Hopefully the test makes sense 😅 Thanks! |
Just as a nice extra info on this conversation, we were able to use this to stream an Elastic Search paged result into a CSV file directly on Azure Blob never storing anything on the local file system. |
I've fixed (or so I think) the version tag on master. If you could rebase your change on top of it would be great. Call me on Whatzapp if you need help doing it ;) |
67bcd63
to
86c76f6
Compare
For example, you can be chunk reading documents from an Elastic Search cluster, and writing as you process them.