forked from rails-api/active_model_serializers
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding a benchmak test structure to help contributors to keep track of how their PR will impact overall performance. It enables developers to create test inside of tests/benchmark. This implementation adds a rake task: ```rake benchmark``` that checkout one commit before, run the test of tests/benchmark, then mover back to the last commit and run it again. By comparing the benchmark results between both commits the contributor will notice if and how much his contribution will impact overall performance.
- Loading branch information
1 parent
820db0b
commit 0c0ec0e
Showing
6 changed files
with
96 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,46 @@ | ||
require "bundler/gem_tasks" | ||
|
||
require 'bundler/gem_tasks' | ||
require 'rugged' | ||
require 'benchmark' | ||
require 'rake/testtask' | ||
|
||
task :default => :test | ||
|
||
Rake::TestTask.new do |t| | ||
t.libs << "test" | ||
t.test_files = FileList['test/**/*_test.rb'] | ||
t.ruby_opts = ['-r./test/test_helper.rb'] | ||
t.verbose = true | ||
end | ||
|
||
task :default => :test | ||
Rake::TestTask.new :benchmark_tests do |t| | ||
t.libs << "test" | ||
t.test_files = FileList['test/**/*_benchmark.rb'] | ||
t.ruby_opts = ['-r./test/test_helper.rb'] | ||
t.verbose = true | ||
end | ||
|
||
task :benchmark do | ||
@repo = Rugged::Repository.new('.') | ||
ref = @repo.head | ||
|
||
actual_branch = ref.name | ||
|
||
set_commit('master') | ||
old_bench = Benchmark.realtime { Rake::Task['benchmark_tests'].execute } | ||
|
||
set_commit(actual_branch) | ||
new_bench = Benchmark.realtime { Rake::Task['benchmark_tests'].execute } | ||
|
||
puts 'Results ============================' | ||
puts "------------------------------------~> (Branch) MASTER" | ||
puts old_bench | ||
puts "------------------------------------" | ||
|
||
puts "------------------------------------~> (Actual Branch) #{actual_branch}" | ||
puts new_bench | ||
puts "------------------------------------" | ||
end | ||
|
||
def set_commit(ref) | ||
@repo.checkout ref | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
require 'test_helper' | ||
|
||
module ActionController | ||
module Serialization | ||
class SerializerTest < ActionController::TestCase | ||
class PostController < ActionController::Base | ||
|
||
def render_with_cache_enable | ||
comment = Comment.new({ id: 1, body: 'ZOMG A COMMENT' }) | ||
author = Author.new(id: 1, name: 'Joao Moura.') | ||
post = Post.new({ id: 1, title: 'New Post', blog:nil, body: 'Body', comments: [comment], author: author }) | ||
|
||
render json: post | ||
end | ||
end | ||
|
||
tests PostController | ||
|
||
def test_render_with_cache_enable | ||
ActionController::Base.cache_store.clear | ||
get :render_with_cache_enable | ||
|
||
expected = { | ||
id: 1, | ||
title: 'New Post', | ||
body: 'Body', | ||
comments: [ | ||
{ | ||
id: 1, | ||
body: 'ZOMG A COMMENT' } | ||
], | ||
blog: { | ||
id: 999, | ||
name: 'Custom blog' | ||
}, | ||
author: { | ||
id: 1, | ||
name: 'Joao Moura.' | ||
} | ||
} | ||
|
||
assert_equal 'application/json', @response.content_type | ||
assert_equal expected.to_json, @response.body | ||
|
||
get :render_with_cache_enable | ||
assert_equal expected.to_json, @response.body | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters