This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Added property for autocorrection #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adressing issue jobandtalent#67, I added a property to set the UITextAutocorrectionType on the underlaying UITextField / UITextView. Is is still turned off by default but the user now has the choice to turn it on.
victorBaro
suggested changes
Mar 20, 2018
|
|
||
| open var autocorrection: UITextAutocorrectionType = .no { | ||
| didSet { | ||
| configureType() |
There was a problem hiding this comment.
Is this needed? configureType() removes the whole view from its superview and generates a new input. I would simply do textInput.autocorrection = autocorrection.
There was a problem hiding this comment.
I agree, you are right.
I made the proposed change and will do the commit soon.
Not the entire text input is re-created but only its autocorrection property is updated when a change to the value is made.
|
Would you please review the changes that I've made after your correction-suggestion? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adressing issue #67, I added a property to set the UITextAutocorrectionType on the underlaying UITextField / UITextView.
Is is still turned off by default but the user now has the choice to turn it on.