Skip to content

change default error callback #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020
Merged

change default error callback #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Callback/KafkaErrorCallback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ final class KafkaErrorCallback
*/
public function __invoke($kafka, int $errorCode, string $reason)
{
if (RD_KAFKA_RESP_ERR__TRANSPORT === $errorCode) {
// non fatal errors are retried by librdkafka
if (RD_KAFKA_RESP_ERR__FATAL !== $errorCode) {
return;
}

Expand Down
38 changes: 2 additions & 36 deletions tests/Unit/Callback/KafkaErrorCallbackTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,51 +11,17 @@
*/
class KafkaErrorCallbackTest extends TestCase
{

public function getConsumerMock()
{
return $this->getMockBuilder(RdKafkaConsumer::class)
->disableOriginalConstructor()
->onlyMethods(['unsubscribe', 'getSubscription'])
->getMock();
}

public function testInvokeWithBrokerException()
{
self::expectException('Jobcloud\Kafka\Exception\KafkaBrokerException');

$consumerMock = $this->getConsumerMock();

$consumerMock
->expects(self::any())
->method('unsubscribe')
->willReturn(null);

$consumerMock
->expects(self::any())
->method('getSubscription')
->willReturn([]);

$callback = new KafkaErrorCallback();
call_user_func($callback, $consumerMock, 1, 'error');
call_user_func($callback, null, RD_KAFKA_RESP_ERR__FATAL, 'error');
}

public function testInvokeWithAcceptableError()
{
$consumerMock = $this->getConsumerMock();

$consumerMock
->expects(self::any())
->method('unsubscribe')
->willReturn(null);

$consumerMock
->expects(self::any())
->method('getSubscription')
->willReturn([]);

$callback = new KafkaErrorCallback();
$result = call_user_func($callback, $consumerMock, RD_KAFKA_RESP_ERR__TRANSPORT, 'error');
$result = call_user_func($callback, null, RD_KAFKA_RESP_ERR__TRANSPORT, 'error');

self::assertNull($result);
}
Expand Down