Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to latest stable version of Kotlin language dependency #1

Open
Cliabhach opened this issue Oct 29, 2018 · 2 comments
Open

Switch to latest stable version of Kotlin language dependency #1

Cliabhach opened this issue Oct 29, 2018 · 2 comments

Comments

@Cliabhach
Copy link

At some point last year, the Kotlin team deprecated org.jetbrains.kotlin:kotlin-stdlib-jre7 and recommended using org.jetbrains.kotlin:kotlin-stdlib-jdk7 instead. It's something to do with the security model of Java 9+'s JVM being more strict about what files are allowed to be in what archive (I think), but the code in the two artifacts is basically the same. So this project could define

'kotlin': '1.2.71'

and

org.jetbrains.kotlin:kotlin-stdlib-jdk7:${versions.kotlin}

without too much trouble. @jobinlawrance what do you think?

@jobinlawrance
Copy link
Owner

Sure, but I am really caught up with something else. I am open to a pull request.

Cliabhach added a commit to Cliabhach/okhttp3-downloadprogress-interceptor that referenced this issue Oct 29, 2018
This also changes the `stdlib` declaration to use `jdk7` instead of `jre7`, resolving issue jobinlawrance#1.
Cliabhach added a commit to Cliabhach/okhttp3-downloadprogress-interceptor that referenced this issue Oct 29, 2018
This also changes the `stdlib` declaration to use `jdk7` instead of `jre7`, resolving issue jobinlawrance#1.
@Cliabhach
Copy link
Author

FYI I've tagged a release including this and two or so minor related changes at https://github.com/Cliabhach/okhttp3-downloadprogress-interceptor/releases/tag/1.0.2-a1 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants