CLN remove backward compat and rely on multiprocessing for win reduction #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The windows py38 deadlock does not appear on master. So maybe this backward compat is required at least for Python 3.8? The py311 failures are already present on master and are therefore unrelated to this PR. |
The py38 failure on the first commit is on macos so I don't think it is related to this PR in fact, I think we both misread this 😅 |
tomMoral
force-pushed
the
CLN_remove_backcompat
branch
from
47c8f04
to
94e58c7
Compare
|
@tomMoral we need to document the change in the changelog. In particular, I think this is a bugfix for nested use of loky under Python 3.11 (compared to the last released version). |
This was referenced Apr 14, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.