This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Update CAS from v1.1.0 to 1.1.1 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giniouxe There are not circle CI configured. I don't know if we need for this project because we don't update every month. |
|
That's a lot of work to maintain the diff between this fork and the original repo. |
|
What was the original reason for forking? (I'm not sure by looking at the commits) |
Quoting @dezande (more or less): The reason was the lack of SAML support. We could possibly get rid of the fork by handling it in the CAS strategy. |
Forwards the XML response received from CASAuth to the fetch_raw_info callback, which now accepts five arguments (cas, options, ticket, user info, and the raw response). Developers who override fetch_raw_info with a Proc are unaffected -- the new argument is silently discarded -- but developers who use a Lambda will need to update their code.
Requires updating webmock; see: bblimke/webmock#683
|
@giniouxe Test run well now |
|
I test with
|
sebn
approved these changes
Apr 24, 2020
yannvery
approved these changes
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the
fetch_raw_infofor read attributes types list (see dlindahl#47).This feature is available in the project dlindahl/omniauth-cas master. I am merging this in this branch.