Add types to exports field in package.json
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Seems reasonable to me, thank you! |
joe-bell
changed the title
moduleResolution: bundlertypes to exports field in package.json
joe-bell
approved these changes
Apr 11, 2023
sebald
referenced
this pull request
in sebald/pattern-analyzer
Apr 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [class-variance-authority](https://togithub.com/joe-bell/cva) | [`0.5.1` -> `0.5.2`](https://renovatebot.com/diffs/npm/class-variance-authority/0.5.1/0.5.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>joe-bell/cva</summary> ### [`v0.5.2`](https://togithub.com/joe-bell/cva/releases/tag/v0.5.2) [Compare Source](https://togithub.com/joe-bell/cva/compare/v0.5.1...v0.5.2) #### What's Changed - Support for `moduleResolution: bundler` (add `types` to `exports` field in `package.json`) by [@​msonnberger](https://togithub.com/msonnberger) in [https://github.com/joe-bell/cva/pull/138](https://togithub.com/joe-bell/cva/pull/138) #### New Contributors - [@​msonnberger](https://togithub.com/msonnberger) made their first contribution in [https://github.com/joe-bell/cva/pull/138](https://togithub.com/joe-bell/cva/pull/138) **Full Changelog**: joe-bell/cva@v0.5.1...v0.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/sebald/pattern-analyzer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
Open
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using TypeScript's new
moduleResolution: bundleroption, TS can't find the declaration file (Could not find a declaration file for module 'class-variance-authority'). By adding the types path to theexportsfield inside package.json, this works again.Additional context
Similar PR with additional info: ikenfin/vite-plugin-sentry#252
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).