fix: issue #147 where map files are not present for esm files #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you @pfried this is great 🖤 |
joe-bell
approved these changes
Apr 26, 2023
sebald
referenced
this pull request
in sebald/pattern-analyzer
May 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [class-variance-authority](https://togithub.com/joe-bell/cva) | [`0.5.2` -> `0.6.0`](https://renovatebot.com/diffs/npm/class-variance-authority/0.5.2/0.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>joe-bell/cva</summary> ### [`v0.6.0`](https://togithub.com/joe-bell/cva/releases/tag/v0.6.0) [Compare Source](https://togithub.com/joe-bell/cva/compare/v0.5.3...v0.6.0) #### What's Changed - `cx` → `clsx` by [@​joe-bell](https://togithub.com/joe-bell) in [https://github.com/joe-bell/cva/pull/152](https://togithub.com/joe-bell/cva/pull/152) **`cva` now uses `clsx` under-the-hood** to concatenate classes with **no breaking changes** to the current experience and **no increase to bundle-size**. The existing `cx` export still exists, but as an alias of `clsx` Bringing additional benefits of: 1. Provides additional support for booleans and variadic strings within `class` or `className` props ```ts const button = cva([true && "button-base", false && "not-rendered"]); // => 'button-base' const buttonConsumer = button({ class: [true && "extra-class"] }); // => 'button-base extra-class' ``` 2. Provides support for [object](https://togithub.com/lukeed/clsx#usage) syntax within `class` or `className` props ```ts const button = cva({ foo: true, bar: false }); // => 'foo baz' ``` **Full Changelog**: joe-bell/cva@v0.5.3...v0.6.0 ### [`v0.5.3`](https://togithub.com/joe-bell/cva/releases/tag/v0.5.3) [Compare Source](https://togithub.com/joe-bell/cva/compare/v0.5.2...v0.5.3) #### What's Changed - fix: issue [#​147](https://togithub.com/joe-bell/cva/issues/147) where map files are not present for esm files by [@​pfried](https://togithub.com/pfried) in [https://github.com/joe-bell/cva/pull/148](https://togithub.com/joe-bell/cva/pull/148) > Thank you [@​pfried](https://togithub.com/pfried)! - fix: Added explicit undefined type to support exactOptionalPropertyTypes option by [@​totto2727](https://togithub.com/totto2727) in [https://github.com/joe-bell/cva/pull/149](https://togithub.com/joe-bell/cva/pull/149) > This has been a long standing issue for me and I'm **so** grateful to [@​totto2727](https://togithub.com/totto2727) for making the fix #### New Contributors - [@​pfried](https://togithub.com/pfried) made their first contribution in [https://github.com/joe-bell/cva/pull/148](https://togithub.com/joe-bell/cva/pull/148) - [@​totto2727](https://togithub.com/totto2727) made their first contribution in [https://github.com/joe-bell/cva/pull/149](https://togithub.com/joe-bell/cva/pull/149) **Full Changelog**: joe-bell/cva@v0.5.2...v0.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/sebald/pattern-analyzer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
Open
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I guess this is all it takes to solve #147 since the files are generated but are not present in the published files in the package
What is the purpose of this pull request?