Skip to content

Commit

Permalink
operator: operator/linter: Change golint confidence in golangci-lint
Browse files Browse the repository at this point in the history
The minimal confidence set to 0 causes golint to report false
possitive message about package godoc. It can be disabled
by changing the confidence.

Message: "should have a package comment, unless it's in another file
for this package (golint)"

REF: golangci/golangci-lint#1556 (comment)
  • Loading branch information
RafalKorepta committed Mar 4, 2021
1 parent 54b16ec commit 6f3ae72
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 7 deletions.
5 changes: 4 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ linters-settings:
- performance
- style
golint:
min-confidence: 0
# The package comment is false positive so the min-confidance needs to be
# set to at least 0.3
# Ref https://github.com/golangci/golangci-lint/issues/1556#issuecomment-744021989
min-confidence: 0.3
gomnd:
settings:
mnd:
Expand Down
1 change: 0 additions & 1 deletion apis/redpanda/v1alpha1/cluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0

// Package v1alpha1 represent Custom Resource definition of the vectorized.io redpanda group
package v1alpha1

import (
Expand Down
1 change: 0 additions & 1 deletion apis/redpanda/v1alpha1/cluster_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0

// Package v1alpha1 represent Custom Resource definition of the vectorized.io redpanda group
package v1alpha1

import (
Expand Down
1 change: 0 additions & 1 deletion pkg/resources/configmap.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0

// Package resources contains reconciliation logic for redpanda.vectorized.io CRD
package resources

import (
Expand Down
1 change: 0 additions & 1 deletion pkg/resources/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0

// Package resources contains reconciliation logic for redpanda.vectorized.io CRD
package resources

import (
Expand Down
1 change: 0 additions & 1 deletion pkg/resources/statefulset.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0

// Package resources contains reconciliation logic for redpanda.vectorized.io CRD
package resources

import (
Expand Down
1 change: 0 additions & 1 deletion pkg/resources/statefulset_update.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0

// Package resources contains reconciliation logic for redpanda.vectorized.io CRD
package resources

import (
Expand Down

0 comments on commit 6f3ae72

Please sign in to comment.