"paste" converted HTML into quill before returning delta #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by setting delta as content to quill and then returning the content fix joelcolucci#3 BREAKING CHANGE: This likely alters the result of any convertHtmlToDelta conversion. Depending of what people are doing with the delta this might break things.
|
Any news @joelcolucci ? |
|
Hey @Xiphe No excuses for the delay. I am reviewing this now and will have an update shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the delta should not change when loaded into a quill instance running in a browser.
This likely alters the result of any
convertHtmlToDeltaconversion. Depending of what people are doing with the delta this might break things.If you'd prefer to provide a non-breaking fix I could alter this PR by either
convertHtmlToDelta(html, exact)convertHtmlToExactDelta(html)QUILLso that I can do this on my own :)I decided to go with the breaking change since I think this should be the default behaviour and as a consumer I would expect the library to work this way.
fix #3 | pre-published as
@xiphe/node-quill-converter@0.3.3-RC.1