Literal::Array: implement #replace, and #insert. add #prepend alias
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to how `#push` works, except it happens at a given `index`, and the implementation and tests are also very similar.
phillipspc
commented
Nov 11, 2024
joeldrapper
reviewed
Nov 11, 2024
joeldrapper
reviewed
Nov 11, 2024
lib/literal/array.rb
Outdated
| when Array | ||
| value | ||
| when Literal::Array | ||
| value.to_a |
There was a problem hiding this comment.
I don’t know if Array#replace(value) will mutate the given value or just use it as a reference. If it doesn’t mutate, we could call .__value__ here instead of .to_a.
phillipspc
force-pushed
the
more-literal-array-improvements
branch
from
aaad8bd to
da58a31
Compare
`#replace` should work with either an Array or Literal::Array. It should raise an ArgumentError for any other class of argument, and it should enforce type checking.
phillipspc
force-pushed
the
more-literal-array-improvements
branch
from
da58a31 to
eb1ed43
Compare
phillipspc
changed the title
#replace, #concat, and #insert. add #prepend alias#replace, and #insert. add #prepend alias
|
@joeldrapper Based on our conversation, I've removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to chip away at #134
My goal was to more or less work my way down the list of "Methods for Assigning" from the ruby docs
From that list, this implements:
#prepend(alias for#unshift)#insert#replaceI'm still not 100% on if I'm always using
Literal.checkcorrectly. And also unsure how thorough to be in tests. Feedback welcome of course!