Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the option to disable checks #259

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove the option to disable checks #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/literal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# frozen_string_literal: true

module Literal
TYPE_CHECKS_DISABLED = ENV["LITERAL_TYPE_CHECKS"] == "false"

autoload :Array, "literal/array"
autoload :Data, "literal/data"
autoload :DataProperty, "literal/data_property"
Expand Down
40 changes: 13 additions & 27 deletions lib/literal/property.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,29 +118,18 @@ def generate_reader_method(buffer = +"")
"\n value\nend\n"
end

if Literal::TYPE_CHECKS_DISABLED
def generate_writer_method(buffer = +"")
buffer <<
(@writer ? @writer.name : "public") <<
" def " <<
@name.name <<
"=(value)\n" <<
" @#{@name.name} = value\nend\n"
end
else # type checks are enabled
def generate_writer_method(buffer = +"")
buffer <<
(@writer ? @writer.name : "public") <<
" def " <<
@name.name <<
"=(value)\n" <<
" self.class.literal_properties[:" <<
@name.name <<
"].check_writer(self, value)\n" <<
" @" << @name.name << " = value\n" <<
"rescue Literal::TypeError => error\n error.set_backtrace(caller(1))\n raise\n" <<
"end\n"
end
def generate_writer_method(buffer = +"")
buffer <<
(@writer ? @writer.name : "public") <<
" def " <<
@name.name <<
"=(value)\n" <<
" self.class.literal_properties[:" <<
@name.name <<
"].check_writer(self, value)\n" <<
" @" << @name.name << " = value\n" <<
"rescue Literal::TypeError => error\n error.set_backtrace(caller(1))\n raise\n" <<
"end\n"
end

def generate_predicate_method(buffer = +"")
Expand Down Expand Up @@ -171,10 +160,7 @@ def generate_initializer_handle_property(buffer = +"")
generate_initializer_coerce_property(buffer)
end

unless Literal::TYPE_CHECKS_DISABLED
generate_initializer_check_type(buffer)
end

generate_initializer_check_type(buffer)
generate_initializer_assign_value(buffer)
end

Expand Down
Loading