-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Moshi 1.x annotation style #529
Add Moshi 1.x annotation style #529
Conversation
This looks great. The one comment I have is, shall we go for |
I intentionally used |
👍 |
When will Moshi be available on the website? |
I don't usually add niche features to the website. Do you need it there? |
I would not call Moshi a niche JSON library. My personal motivation to add the feature was to have it on the website. |
I like to encourage you once again to also list Moshi on the website. |
Hi guys, please add it to the website :) Really thankful to you, you guys are awesome! |
Yeah, lets add it to the website. Clearly Moshi is doing well. @mark-mush Did you know this project does support Moshi and you can use this feature from Maven/Gradle/etc? |
I figured that it was possible, I'm finishing a course on Android programing so I wanted to use the best/latest technology, I wasn't quite sure how to use the jsonschema2pojo library with gradle/maven ^_^; |
@johnjohndoe This is up on the site now 👍 |
Awesome! 🤗 Thanks a lot. Works nicely! |
Yes, that's the change. The backend parses this string to an AnnotationStyle enum using valueOf, so there's nothing more to do. If you're familiar with Clojure, changes on the website are very easy. Just |
Resolves #523.