Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Moshi 1.x annotation style #529

Merged
merged 1 commit into from
Mar 20, 2016

Conversation

johnjohndoe
Copy link
Contributor

Resolves #523.

@joelittlejohn joelittlejohn changed the title Add Moshi 1.x. Add Moshi 1.x annotation style Mar 14, 2016
@joelittlejohn
Copy link
Owner

This looks great.

The one comment I have is, shall we go for MOSHI instead of MOSHI1 (throughout the code-base)? There may never be a Moshi 2.x, and if there is, we can add MOSHI2.

@johnjohndoe
Copy link
Contributor Author

I intentionally used MOSHI1 as it is being used for JACKSON1. I consider Moshi as other libraries by Square to be a fast moving target. Therefore, I would suggest using MOSHI1 over MOSHI.

@joelittlejohn joelittlejohn added this to the 0.4.23 milestone Mar 20, 2016
@joelittlejohn joelittlejohn merged commit 2aa7a34 into joelittlejohn:master Mar 20, 2016
@johnjohndoe johnjohndoe deleted the moshi-integration branch March 21, 2016 09:38
@johnjohndoe
Copy link
Contributor Author

👍

@joelittlejohn joelittlejohn modified the milestones: 0.4.22, 0.4.23 Mar 29, 2016
@joelittlejohn joelittlejohn modified the milestones: 0.4.23, 0.4.22 May 18, 2016
@johnjohndoe
Copy link
Contributor Author

When will Moshi be available on the website?

@joelittlejohn
Copy link
Owner

I don't usually add niche features to the website. Do you need it there?

@johnjohndoe
Copy link
Contributor Author

I would not call Moshi a niche JSON library. My personal motivation to add the feature was to have it on the website.

@johnjohndoe
Copy link
Contributor Author

johnjohndoe commented Jun 16, 2017

I like to encourage you once again to also list Moshi on the website.

@ghost
Copy link

ghost commented Jun 16, 2017

Hi guys, please add it to the website :)
Moshi is better than Gson and Jackson, especially when combined with Retrofit. I wanted to use it for my project, but then discovered that the website doesn't support Moshi annotations, this is how I found your convo, many developers are switching to Moshi, it was developed by the same guys that invented Gson.

Really thankful to you, you guys are awesome!

@joelittlejohn
Copy link
Owner

Yeah, lets add it to the website. Clearly Moshi is doing well.

@mark-mush Did you know this project does support Moshi and you can use this feature from Maven/Gradle/etc?

@ghost
Copy link

ghost commented Jun 16, 2017

I figured that it was possible, I'm finishing a course on Android programing so I wanted to use the best/latest technology, I wasn't quite sure how to use the jsonschema2pojo library with gradle/maven ^_^;

@joelittlejohn
Copy link
Owner

@johnjohndoe This is up on the site now 👍

@johnjohndoe
Copy link
Contributor Author

Awesome! 🤗 Thanks a lot. Works nicely!
Out of curiosity: Was this the only change needed? I did not expect such a small change.

@joelittlejohn
Copy link
Owner

joelittlejohn commented Jun 16, 2017

Yes, that's the change. The backend parses this string to an AnnotationStyle enum using valueOf, so there's nothing more to do.

If you're familiar with Clojure, changes on the website are very easy. Just lein ring server to run it and test locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants