Added class methods support #4
Conversation
| send(:"__#{name}", *args, **kwargs) | ||
| end | ||
| meta.send :define_method, :singleton_method_added do |name| | ||
| next if name == :singleton_method_added |
There was a problem hiding this comment.
Didn't found this documented anywhere in ruby, but looks like defining singleton_method_added also calls itself. Tried isolating this on a simple example just in case define_method or send where causing it somehow, but it also happened on isolation
| meta.send :define_method, :method_added do |name| | ||
| meta.send :remove_method, :method_added | ||
| meta.send :remove_method, :singleton_method_added | ||
|
|
||
| alias_method :"__#{name}", name | ||
| define_method name do |*args, **kwargs, &block| | ||
| sig_args.each.with_index do |arg, i| | ||
| args[i] => ^arg | ||
| end | ||
|
|
||
| kwargs.each do |key, value| | ||
| value => ^(sig_kwargs[key]) | ||
| end | ||
| sig_check.call(self, name, *args, **kwargs, &block) | ||
| end | ||
| end | ||
|
|
||
| result = if block | ||
| send(:"__#{name}", *args, **kwargs, &block) | ||
| else | ||
| send(:"__#{name}", *args, **kwargs) | ||
| end | ||
| meta.send :define_method, :singleton_method_added do |name| | ||
| next if name == :singleton_method_added | ||
|
|
||
| result => ^returns if returns != NULL | ||
| meta.send :remove_method, :singleton_method_added | ||
| meta.send :remove_method, :method_added |
There was a problem hiding this comment.
So, we wait for either a singleton method or an instance method, whatever happens first will remove both method_added callbacks
test/delivered/signature.rb
Outdated
| end | ||
|
|
||
| sig String, returns: Array | ||
| def find_by_name(name) |
There was a problem hiding this comment.
Typo? should be a class method I think.
|
Other than the typo and a few rubocop failures, this looks great! If you can correct those, I can merge this. Thanks so much. |
|
Cool! Just saw those rubocop offences while fixing the typo. I'll take a look and push an update here soon, Thanks! |
Summary
Solves #3 . it attempts to refactor the
sigmethod to cover for class methods along with adding specs for it. Another early approach was to use a separateclass_sigmethod, but I thought that could end up being too confusingAlso addresses some errors I found when check the gemspec while installing local dependencies, but let me know if that's not needed for whatever reason