Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add live coding to ch1 exercises #32

Merged
merged 15 commits into from
Sep 15, 2024
Merged

Add live coding to ch1 exercises #32

merged 15 commits into from
Sep 15, 2024

Conversation

joelostblom
Copy link
Owner

@joelostblom joelostblom commented Sep 10, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link

Hello! I've built a preview of your PR so that you can compare it to the current main branch:

@joelostblom joelostblom changed the title Fix minor aspects of ch1 exercises Add live coding to ch1 exercises Sep 13, 2024
@joelostblom joelostblom marked this pull request as ready for review September 13, 2024 21:59
@joelostblom
Copy link
Owner Author

joelostblom commented Sep 13, 2024 •
edited
Loading

@rorywhite200 This is ready for review. It ended up being much more than just a small fix, but now we have live exercise with at least some type of solution checking, which I wanted in thebook before receiving the feedback from the students.

You might have to build locally, I had some issues with the gh actions timeing out earlier today, not sure why. Nvm the preview build seem to work now!

I will put together some questions to send to the students and ask for your review there too.

We could consider having all the exercises collapsed by default maybe; it looks more orderly:

image

But then they wouldn't be searchable with ctrl + f which is a larger disadvantage I think

rorywhite200
rorywhite200 reviewed Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@rorywhite200 rorywhite200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The live coding exercises are really cool! The first one is working well for me for Altair. I've made a few suggestions for the tooltip exercise.

  1. Updating the exercise name so it has access to the imports in setup
  2. Adding a hint and solution for exercise

textbook/1_intro.qmd Outdated Show resolved Hide resolved
textbook/1_intro.qmd Outdated Show resolved Hide resolved
textbook/1_intro.qmd Outdated Show resolved Hide resolved
@joelostblom @rorywhite200
Make tooltip exercise work as intended
3b34b26 
Co-authored-by: rorywhite200 <125914446+rorywhite200@users.noreply.github.com>
@joelostblom
Copy link
Owner Author

Great, thank you! I missed that. Committed your suggestions and merging

@joelostblom joelostblom merged commit a5a2202 into main Sep 15, 2024
1 check passed
@joelostblom joelostblom deleted the ch1-exercise-fixup branch September 15, 2024 05:04
@joelostblom joelostblom mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rorywhite200 rorywhite200 rorywhite200 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelostblom @rorywhite200