-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create chapter 2 content #36
base: main
Are you sure you want to change the base?
Conversation
Hello! I've built a preview of your PR so that you can compare it to the current
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great overall @rorywhite200 ! I have left some comments in addition to our discussion today. I think one of the biggest things left to decide is what to do with the data not starting from 0
…ation examples and add first draft of final mission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work overall @rorywhite200! I really like how this chapter is shaping up and it will be an important improvement to how the material is currently taught I think. I have made quite a few comments with suggestions, maybe I should have made commits instead that you could review, but hopefully this works ok. I only have the Mission section left, but don't want to lose all of these, so I am submitting them now. Once you have had a read and tried implement those that make sense to you, we can have another call and discuss any disagreements or final polish.
expand learning outcomes for chapter 2 Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
…ancy (all now comes from GBD 2021)
While these can be useful headsup at time, they are mostly distracting when teaching other topics such as viz.
`+ aes` clarifies the ability to change aes for an existing chart. `vars` is preferred of `~` when faceting (it's the equivalent to aes in a faceting context)
close #55