Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chapter 2 content #36

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

Create chapter 2 content #36

wants to merge 43 commits into from

Conversation

rorywhite200
Copy link
Collaborator

@rorywhite200 rorywhite200 commented Sep 12, 2024

close #55

Copy link

Hello! I've built a preview of your PR so that you can compare it to the current main branch:

Copy link
Owner

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great overall @rorywhite200 ! I have left some comments in addition to our discussion today. I think one of the biggest things left to decide is what to do with the data not starting from 0

textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/img/grouping-strategies.gif Outdated Show resolved Hide resolved
textbook/data_processing/alcohol-lifespan.py Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
Copy link
Owner

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work overall @rorywhite200! I really like how this chapter is shaping up and it will be an important improvement to how the material is currently taught I think. I have made quite a few comments with suggestions, maybe I should have made commits instead that you could review, but hopefully this works ok. I only have the Mission section left, but don't want to lose all of these, so I am submitting them now. Once you have had a read and tried implement those that make sense to you, we can have another call and discuss any disagreements or final polish.

textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
textbook/2_grouping.qmd Show resolved Hide resolved
textbook/2_grouping.qmd Outdated Show resolved Hide resolved
rorywhite200 and others added 6 commits November 4, 2024 09:13
expand learning outcomes for chapter 2

Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft chapter 2
2 participants