Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Verify if the external URL contains 'tel:' and 'mailto:' links. #65

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

solilin
Copy link
Contributor

@solilin solilin commented Oct 19, 2023

The app was crashing when external links included 'mailto:' or 'tel:'. This pull request adds a feature to validate external URLs for the presence of 'tel:' and 'mailto:' links, aiming to enhance both usability and accessibility on the platform.

I'm not a Swift programmer, so , add your thoughts about is correct or not, please.

@joemasilotti
Copy link
Owner

Thanks for this @solilin! I swapped the logic to look for non http(s) URLs instead of explicitly matching sms: and tel:.

Can you give this a try and let me know if it still works for you?

@solilin
Copy link
Contributor Author

solilin commented Oct 20, 2023

This solution is much more elegant, thank you for your hard work. Everything is working as expected now.

@joemasilotti joemasilotti merged commit fff57ce into joemasilotti:main Oct 20, 2023
1 check passed
@janz93
Copy link

janz93 commented Mar 12, 2024

@joemasilotti we are currently facing the issue that is described here in this PR. Would it be possible to have a new release with this feature included? In the current Release 0.3.0 is this not included

@joemasilotti
Copy link
Owner

Development on this repo has been paused - everything is getting merged into the turbo-navigator branch on turbo-ios.

@janz93
Copy link

janz93 commented Mar 12, 2024

Ah okay. If I understood the documentation correctly it is not necessary anymore to add the TurboNavigator dependency. Instead the default Turbo dependency is enough if the Turbo-Navigator branch is used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants