Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Code Formatting #58

Closed
joemphilips opened this issue Feb 28, 2020 · 5 comments · Fixed by #188
Closed

TODO: Code Formatting #58

joemphilips opened this issue Feb 28, 2020 · 5 comments · Fixed by #188
Labels
CI/Tests This issue is related to CI/Test pipeline. enhancement New feature or request good first issue Good for newcomers

Comments

@joemphilips
Copy link
Owner

joemphilips commented Feb 28, 2020

Right now we don't have any automated code formatting scheme.
It is nice to have formatting pipeline in CI.

@joemphilips joemphilips added enhancement New feature or request CI/Tests This issue is related to CI/Test pipeline. good first issue Good for newcomers labels Feb 28, 2020
@knocte
Copy link
Collaborator

knocte commented Feb 28, 2020

Via fantomas?

@joemphilips
Copy link
Owner Author

@knocte probably, I don't know what is the state of the art.

@knocte
Copy link
Collaborator

knocte commented Feb 28, 2020

I think fantomas is the state of the art, if not the only option. But I wouldn't make use of it at least until this PR is merged: fsprojects/fantomas#649 otherwise the inconsistency between having a space before parenthesis or not becomes too annoying.

@joemphilips
Copy link
Owner Author

Thanks for the info. I think it still has some benefits without that feature, but there is no hurry.

@knocte
Copy link
Collaborator

knocte commented Feb 28, 2020

I don't know; to me, having different spacing style depending on if the function called/defined starts with an uppercase letter or not, is master-level of bikeshedding.

knocte added a commit to knocte/DotNetLightning that referenced this issue Apr 25, 2022
knocte added a commit to knocte/DotNetLightning that referenced this issue Apr 25, 2022
knocte added a commit to knocte/DotNetLightning that referenced this issue Apr 25, 2022
knocte added a commit to knocte/DotNetLightning that referenced this issue Apr 25, 2022
knocte added a commit to knocte/DotNetLightning that referenced this issue Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/Tests This issue is related to CI/Test pipeline. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants