Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with python 3.x #4

Closed
wants to merge 1 commit into from

Conversation

ziadsawalha
Copy link
Contributor

I got errors trying to run pythonwhois in python 3.x. I believe these changes will fix that.

I ran tests successfully in python 3.3 and 2.7.

@joepie91
Copy link
Owner

joepie91 commented Mar 2, 2014

Sorry for the delayed response, I've been crazy busy the past two weeks.

I've run tests under Python 2.6 as well, and these succeeded. The only possible drawback of merging this, would be that there'd be no Python 2.5 compatibility (due to the exception syntax) - however, as far as I am aware 2.5 is not really shipped with any non-EOL distributions anymore, so it shouldn't be too much of an issue.

I should point out that while I can test on Python 3, my primary testing still takes place on Python 2(.7), and I can't guarantee that I won't overlook something that might break Python 3 compatibility in the future. I'll do my best, though :)

Sidenote: Your pull request targets the master branch; since GitHub won't let me retarget it, I'll manually merge it into develop instead, and it'll end up in the next release. That release should happen in a few days at most.

joepie91 added a commit that referenced this pull request Mar 2, 2014
@joepie91 joepie91 closed this Mar 2, 2014
@ziadsawalha
Copy link
Contributor Author

Thanks!

Would you accept a pull request to use tox for testing multiple versions of python?

@ziadsawalha ziadsawalha deleted the py33 branch March 3, 2014 23:44
@joepie91
Copy link
Owner

joepie91 commented Mar 4, 2014

Assuming it wouldn't create any additional significant workload for me (which it doesn't seem to, judging from the site), that'd be very welcome :)

@ziadsawalha ziadsawalha restored the py33 branch March 14, 2014 21:29
@ziadsawalha
Copy link
Contributor Author

@joepie91 - #7 includes tox and a bunch of python 3.3 fixes as a result.

@joepie91 joepie91 mentioned this pull request Sep 6, 2015
Sir-Fenrir pushed a commit to Sir-Fenrir/whois-oracle that referenced this pull request Jun 17, 2016
…x/fix-for-gg-domains to develop

* commit 'aaa7a6cba8d280f1e53d1b4498387180be0bdb0e':
  REF: Changed the default cooldown to 4 seconds REF: Changed the time out for a WHOIS request to 3 seconds
  FIX: Fixed failure for gg domains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants