Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle multiline sql without spaces #215

Open
wants to merge 1 commit into
base: typescript
Choose a base branch
from
Open

fix: Handle multiline sql without spaces #215

wants to merge 1 commit into from

Commits on Jun 22, 2022

  1. fix: Handle multiline sql without spaces 

    When replacing multiline comment, it is now done with a space instead of
nothing since this would be valid sql:
```sql
SELECT pid FROM/*comment*/pg_stat_activity;
```
But replacing the comment with "" would make it incorrect.

Also join the lines in query on getContent with a space to remove the
need for spaces in the sql. Previously this sql:
```sql
SELECT some_column
FROM some_table;
```
would result in this error: `[error] column "some_columnfrom" does not
exist`
This PR fixes that.
    @nossrannug
    nossrannug committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    45e465a View commit details
    Browse the repository at this point in the history