Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

Plugin interferes with <cr> pumvisible() ? maps #43

Open
karoliskoncevicius opened this issue Feb 25, 2019 · 1 comment
Open

Plugin interferes with <cr> pumvisible() ? maps #43

karoliskoncevicius opened this issue Feb 25, 2019 · 1 comment

Comments

@karoliskoncevicius
Copy link

This line: https://github.com/joereynolds/vim-minisnip/blob/master/plugin/minisnip.vim#L46 seems to interfere with a map that makes <enter> key select completions:

inoremap <expr> <cr> pumvisible() ? "\<c-y>" : "\<cr>"

Managed to find it and add a custom map to <Plug>(minisnip-complete) in order to disable the effect. But it took some time and probably could potentially confuse users.

@arp242
Copy link

arp242 commented Jul 29, 2019

I think this is kind of a case where a personal preference of mine snuck in as a keybind.

Changing this to ^Y probably makes more sense? That's the default Vim mapping ("Yes: Accept the currently selected match and stop completion."). Then your <CR> mapping should also work as expected for this, I think?

joereynolds pushed a commit that referenced this issue Nov 13, 2019
<CR> isn't the standard Vim mapping to accept the completion, <C-y> is.
This is just a personal preference that snuck in when I wrote the
completion (#6).

Fixes #42 and #43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants