[TypeRecovery] Re-work for Fixed Iteration Strategy & Using POSSIBLE_TYPES
#3733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits
POSSIBLE_TYPES
in order to avoid clashing with the must-style ofDYNAMIC_TYPE_HINT_FULL_NAME
Breaking Changes
<returnValue>.<indexAccess>.<indexAccess>.
one needs an iteration count of at least 3.File
and the pass will iterate throughMethods
from that file while checking variables captured in by a parent scope.Main Changes
GraphCache
object to theTypeRecoveryState
Next Steps
TODO: Work towards a fully
ConcurrentWriterCpgPass
solution by expanding upon theGraphCache
TODO: Make use of
Declaration
nodes in the symbol table to avoid many repeated AST crawlsCloses PR #3551
cc: @ml86 @max-leuthaeuser