workaround for scala completion bug #4791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on stage: remove module-info.class from dependency jars - a hacky workaround for a scala3 compiler bug: scala/scala3#20421 Fixes #4625
maltek
reviewed
Jul 22, 2024
| .forEach { jar => | ||
| val zipFs = FileSystems.newFileSystem(jar) | ||
| zipFs.getRootDirectories.forEach { zipRootDir => | ||
| Files.list(zipRootDir).filter(_.toString == "/module-info.class").forEach { moduleInfoClass => |
There was a problem hiding this comment.
does this comparison with a / work on Windows?
There was a problem hiding this comment.
Probably yes, because it's within a java ZipFileSystem. I'll give it a quick whirl in my VM though.
There was a problem hiding this comment.
just updating crowdstrike, won't be long :)
There was a problem hiding this comment.
yes it works on windows
maltek
reviewed
Jul 22, 2024
in that case we'd adapt the logic, but my hope is that the compiler bug is fixed by then... |
maltek
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on stage: remove module-info.class from dependency jars - a hacky workaround for a
scala3 compiler bug: scala/scala3#20421
Fixes #4625