[jssrc2cpg] Pass JVM max memory setting to astgen #4990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-leuthaeuser
requested review from
Ferada,
maltek,
johannescoetzee and
mpollmeier
maltek
approved these changes
Oct 4, 2024
mpollmeier
approved these changes
Oct 4, 2024
| } | ||
|
|
||
| private def nodejsSpaceSize: Int = { | ||
| Math.max((0.75 * getMaxHeapSizeInMB).toInt, 8192) // as default we set 8G minimum |
There was a problem hiding this comment.
I understand that this isn't really a change, but I'm still wondering if setting a (rather high) minimum is the right idea, given that it may exceed the free memory, and/or even the physically available memory.
There was a problem hiding this comment.
I would assume this memory will be long freed when it needs to be reclaimed by java again. This is done under the assumption the end user will set up java mem thinking that this is all it takes for the cpg process
|
With some local testing it turned out that the nodejs binary astgen we build using pkg does not accept any settings from env variables since this change here: vercel/pkg-fetch@7f3403b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://shiftleftinc.atlassian.net/browse/SEN-3282