[c2cpg] Implemented cached header file loading #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on linux kernel, results look good. No difference in timing, stdout is much shorter. export SL_LOGGING_LEVEL=debug
time ./c2cpg.sh -J-Xmx90g -o /home/mp/tmp/cpgtesting/linux-kernel/linux4.fg ~/tmp/cpgtesting/linux-kernel/linux-4.1.16/ | tee c2cpg.out
git:(max/cachedHeaderLoading)$
15043,57s user 9879,91s system 1070% cpu 38:48,85 total
-rw-r--r-- 1 mp mp 12M 11. Okt 09:57 c2cpg-cached-header-loading.out
git:(master)$
14664,01s user 9992,68s system 1058% cpu 38:48,77 total
-rw-r--r-- 1 mp mp 21M 11. Okt 10:52 c2cpg-master.outstd outputs: |
max-leuthaeuser
changed the title
mpollmeier
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs some testing for (very) large projects.
Caching all the header file contents may make things worse compared to (re-) reading them from disk and GC immediately/soonish.