[javasrc2cpg] Fix record accessor call receiver in pattern matches #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml86
approved these changes
Feb 10, 2025
johannescoetzee
deleted the
johannes/javasrc2cpg/pattern-receiver-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pattern matching on, for example, a
record Foo(String value){}, the field accessor callFoo foo; foo.value()was being created withfooas an argument and not a receiver which, in turn, breaks dataflows. This PR fixes this. I only updated one unit test to demonstrate this, but will useX.receiverconsistently when redoing the unit tests for the new pattern variable initialization representation.