We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PiwikTracker.track
url-join had a bug, leading to an additional "/" that was appended to the URL send with PiwikTracker.track.
url-join
# with url-join 1.1.0 $ node -pe "require('url-join')('/path', '')" /path/ $ node -pe "require('url-join')('/', '')" // # with url-join 4.0.0 $ node -pe "require('url-join')('/path', '')" /path $ node -pe "require('url-join')('/', '')"
Piwik React Router has url-join currently locked at version ^1.1.0, so an update should fix this.
^1.1.0
Is there a specific reason why urljoin(loc.pathname, loc.search) is used instead of loc.pathname + loc.search?
urljoin(loc.pathname, loc.search)
loc.pathname + loc.search
The text was updated successfully, but these errors were encountered:
Fix joernroeder#51 by updating url-join version to suggested
a95f0f9
4cd2d77
15c7908
I noticed the same, updating url-join dependency will solve this. Hoping the fix will be merged into the main branch.
Sorry, something went wrong.
No branches or pull requests
url-join
had a bug, leading to an additional "/" that was appended to the URL send withPiwikTracker.track
.Piwik React Router has
url-join
currently locked at version^1.1.0
, so an update should fix this.Is there a specific reason why
urljoin(loc.pathname, loc.search)
is used instead ofloc.pathname + loc.search
?The text was updated successfully, but these errors were encountered: