Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to package.json and fix bug in smoothie.d.ts #82

Merged
merged 1 commit into from
May 14, 2017
Merged

Add types to package.json and fix bug in smoothie.d.ts #82

merged 1 commit into from
May 14, 2017

Conversation

TrentHouliston
Copy link
Contributor

Add types to the package.json file so they can be found when importing it as a module.
Also there was a missing closing comment in the typescript file which prevented it from working.

@drewnoakes drewnoakes merged commit 5aa0c1c into joewalnes:master May 14, 2017
@drewnoakes
Copy link
Collaborator

Hey Trent. Small world! Thanks for the fixes.

@TrentHouliston
Copy link
Contributor Author

TrentHouliston commented May 14, 2017 via email

@drewnoakes
Copy link
Collaborator

That's awesome. The debugger looks great too. Wish we'd gotten ours online somewhere with some recorded data to play around with.

I'll look at getting a release out now.

@drewnoakes
Copy link
Collaborator

1.29.1 should be up on npm now. Let me know if you have any problems, and thanks again.

Caught up with Josiah as he passed through London at the end of his travels. Would be good to see the rest of you guys too. Maybe in Nagoya. Are you going?

@TrentHouliston
Copy link
Contributor Author

Thanks, Seems to be working great.
And yes we will be in Nagoya, see you there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants